A.91. Release 4.1.18

Modify the replication slot name conversion in sample scripts to support for the hostname in uppercase. (Bo Peng)

Replication slots are automatically created or deleted in the scripts which are executed during failover or online recovery. Since uppercase can't be used for a replication slot name, modify these scripts to convert the hostname to lowercase.

Patch is created by Sheikh Wasiu Al Hasib and modified by Bo Peng.

Remove unnecessary logging line. (Tatsuo Ishii)

Debug message "unset_tx_started_by_multi_statement_query is called in CommandComplete" was accidentally left.

Fix Describe() so that it does not abort with portal created by DECLARE. (Tatsuo Ishii)

When DECLARE foo CURSOR FOR is executed, a portal named "foo" is automatically created by PostgreSQL. As the portal is not managed by Pgpool-II, "Describe foo" message failed with "unable to execute Describe. unable to get the bind message" error.

To fix this, make Describe() create a dummy write query context so that the describe message is sent to primary (streaming replication mode) or all nodes (replication/snapshot isolation mode).

Also add test case 080 for this commit.

This problem was reported and analyzed by Heather Lapointe.

Discussion: https://www.pgpool.net/pipermail/pgpool-general/2023-September/008995.html

Remove duplication definitions of NAMEDATALEN. (Tatsuo Ishii)

The definition for NAMEDATALEN is now in src/include/pg_config_manual.h only. Also replace POOL_NAMEDATALEN with NAMEDATALEN in src/utils/pool_select_walker.c.

Discussion: https://www.pgpool.net/pipermail/pgpool-hackers/2023-August/004366.html

Modify "Pgpool-II + Watchdog Setup Example" to mention that pcp_listen_addresses = '*' is required to allow PCP to listen on all addresses.